Refactor HttpClient-based transports to Publisher-based approach - #1079
Open
Kehrlann wants to merge 4 commits into
Open
Refactor HttpClient-based transports to Publisher-based approach#1079Kehrlann wants to merge 4 commits into
Kehrlann wants to merge 4 commits into
Conversation
Kehrlann
added
area/client
P1
Kehrlann
force-pushed
the
dgarnier/issue-620-refactor-http-client-chains
branch
from
August 7, 2026 16:14
16fee90 to
30dc4d3
Compare
9 tasks
Kehrlann
force-pushed
the
dgarnier/issue-620-refactor-http-client-chains
branch
from
August 27, 2026 11:49
30dc4d3 to
bf47603
Compare
…leaking the httpClient reference due to a cycle Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf> Signed-off-by: Dariusz Jędrzejczyk <2554306+chemicL@users.noreply.github.com>
Fixes #1042 Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Kehrlann
marked this pull request as ready for review
August 31, 2026 15:11
Kehrlann
force-pushed
the
dgarnier/issue-620-refactor-http-client-chains
branch
from
August 31, 2026 15:11
b897c12 to
bbb3330
Compare
Kehrlann
changed the title
Kehrlann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor HttpClient use to avoid capturing the sseSink that leads to leaking the httpClient reference due to a cycle (see #620).
This rewrites the
HttpClientstreaming support from aBodySubscriberpushing messages to aPublisher-based approach.This avoids the
HttpClientcyclic reference we had in the previous implementation. The tradeoff is that we have to perform line parsing manually with aUtf8LineDecoderwe maintain.We can batch this rework with performance fixes reading large SSE events (see #1042)
Fixes #1042
Fixes #620
(Rebased @chemicL 's work on issue #620)